From cd7f3dfd8df62e6506b6dd8f2cabe1c64fa452fd Mon Sep 17 00:00:00 2001
From: Yarmo Mackenbach <yarmo@yarmo.eu>
Date: Thu, 3 Jun 2021 11:55:08 +0200
Subject: [PATCH] Fix handling of keys with non-proof notations

---
 src/keys.js       |  4 ++++
 test/keys.test.js | 22 ++++++++++++++++++++++
 2 files changed, 26 insertions(+)

diff --git a/src/keys.js b/src/keys.js
index 2c97d5f..b5a8f78 100644
--- a/src/keys.js
+++ b/src/keys.js
@@ -246,6 +246,10 @@ exports.process = (publicKey) => {
 
       if ('selfCertifications' in user && user.selfCertifications.length > 0) {
         const notations = user.selfCertifications[0].rawNotations
+        usersOutput[i].notations = notations
+          .filter(({ name, humanReadable }) => humanReadable && name === 'proof@metacode.biz')
+          .map(({ value }) => openpgp.util.decode_utf8(value))
+        
         usersOutput[i].claims = notations.map(
           ({ name, value, humanReadable }) => {
             if (humanReadable && name === 'proof@metacode.biz') {
diff --git a/test/keys.test.js b/test/keys.test.js
index 684be42..786a994 100644
--- a/test/keys.test.js
+++ b/test/keys.test.js
@@ -23,6 +23,7 @@ const doipjs = require('../src')
 
 const pubKeyFingerprint = `3637202523e7c1309ab79e99ef2dc5827b445f4b`
 const pubKeyEmail = `test@doip.rocks`
+
 const pubKeyPlaintext = `-----BEGIN PGP PUBLIC KEY BLOCK-----
 
 mQGNBF+036UBDACoxWRdp7rBAFB2l/+dxX0XA50NJC92EEacB5L0TnC0lP/MsNHv
@@ -49,6 +50,19 @@ x77L7mBkREbuZpFoD/c=
 =w7qB
 -----END PGP PUBLIC KEY BLOCK-----`
 
+const pubKeyWithOtherNotations = `-----BEGIN PGP PUBLIC KEY BLOCK-----
+
+mDMEX9Mt6xYJKwYBBAHaRw8BAQdAch8jfp+8KHH5cy/t45GjPvl6dkEv2soIy9fo
+Oe9DbP20EVlhcm1vJ3MgRXZpbCBUd2luiNsEExYIAIMCGwMFCwkIBwIGFQoJCAsC
+BBYCAwECHgECF4AWIQTeePcduHH8EU2iM3aw5zJVrULhnwUCX9MuHBkUgAAAAAAN
+AANldmlsQHlhcm1vLmV1eWVzMBSAAAAAABIAFXByb29mQG1ldGFjb2RlLmJpemRu
+czp5YXJtby5ldT90eXBlPVRYVAAKCRCw5zJVrULhn4DtAQCVkyI8UxUbkxspXkWB
+qUL+3uqCl9gTbNImhv/OxxJdEAEAqf8SJ9FSeAwgWhPHOidR1m+J6/qVdAJdp0HJ
+Yn6RMQ8=
+=Oo3X
+-----END PGP PUBLIC KEY BLOCK-----`
+
+
 describe('keys.fetchURI', () => {
   it('should be a function (1 argument)', () => {
     expect(doipjs.keys.fetchURI).to.be.a('function')
@@ -124,4 +138,12 @@ describe('keys.process', () => {
       'key',
     ])
   })
+  it('should ignore non-proof notations', async () => {
+    const pubKey = await doipjs.keys.fetchPlaintext(pubKeyWithOtherNotations)
+    const obj = await doipjs.keys.process(pubKey)
+    console.log(obj.users[0]);
+    expect(obj.users).to.be.lengthOf(1)
+    expect(obj.users[0].notations).to.be.lengthOf(1)
+    expect(obj.users[0].notations[0]).to.be.equal('dns:yarmo.eu?type=TXT')
+  })
 })