myriation/doipjs
1
0
Fork 0
forked from Mirrors/doipjs
Code Pull requests Packages 1 Activity

Refactor bad variable names

Browse source
This commit is contained in:
Yarmo Mackenbach 2021-04-30 12:28:01 +02:00
parent fa5af3ab2d
commit 2676d4445f
No known key found for this signature in database
GPG key ID: 37367F4AF4087AD1
1 changed files with 22 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
src/claim.js
View file

@ -51,8 +51,8 @@ class Claim {
this._uri = data.uri this._uri = data.uri
this._fingerprint = data.fingerprint this._fingerprint = data.fingerprint
this._status = data.status this._status = data.status
this._dataMatches = data.dataMatches this._matches = data.matches
this._verification = data.verification this._result = data.result
break break
default: default:
@ -79,8 +79,8 @@ class Claim {
this._uri = uri ? uri : null this._uri = uri ? uri : null
this._fingerprint = fingerprint ? fingerprint : null this._fingerprint = fingerprint ? fingerprint : null
this._status = E.ClaimStatus.INIT this._status = E.ClaimStatus.INIT
this._dataMatches = null this._matches = null
this._verification = null this._result = null
} }
get uri() { get uri() {
@ -99,14 +99,14 @@ class Claim {
if (this._status === E.ClaimStatus.INIT) { if (this._status === E.ClaimStatus.INIT) {
throw new Error('This claim has not yet been matched') throw new Error('This claim has not yet been matched')
} }
return this._dataMatches return this._matches
} }
get result() { get result() {
if (this._status !== E.ClaimStatus.VERIFIED) { if (this._status !== E.ClaimStatus.VERIFIED) {
throw new Error('This claim has not yet been verified') throw new Error('This claim has not yet been verified')
} }
return this._verification return this._result
} }
set uri(uri) { set uri(uri) {
@ -138,12 +138,12 @@ class Claim {
throw new Error("Cannot change a claim's status") throw new Error("Cannot change a claim's status")
} }
set dataMatches(anything) { set matches(anything) {
throw new Error("Cannot change a claim's dataMatches") throw new Error("Cannot change a claim's matches")
} }
set verification(anything) { set result(anything) {
throw new Error("Cannot change a claim's verification data") throw new Error("Cannot change a claim's verification result")
} }
/** /**
@ -158,7 +158,7 @@ class Claim {
throw new Error('This claim has no URI') throw new Error('This claim has no URI')
} }
this._dataMatches = [] this._matches = []
claimDefinitions.list.every((name, i) => { claimDefinitions.list.every((name, i) => {
const def = claimDefinitions.data[name] const def = claimDefinitions.data[name]
@ -171,10 +171,10 @@ class Claim {
const candidate = def.processURI(this._uri) const candidate = def.processURI(this._uri)
if (candidate.match.isAmbiguous) { if (candidate.match.isAmbiguous) {
// Add to the possible candidates // Add to the possible candidates
this._dataMatches.push(candidate) this._matches.push(candidate)
} else { } else {
// Set a single candidate and stop // Set a single candidate and stop
this._dataMatches = [candidate] this._matches = [candidate]
return false return false
} }
@ -209,8 +209,8 @@ class Claim {
opts = mergeOptions(defaults.opts, opts ? opts : {}) opts = mergeOptions(defaults.opts, opts ? opts : {})
// For each match // For each match
for (let index = 0; index < this._dataMatches.length; index++) { for (let index = 0; index < this._matches.length; index++) {
const claimData = this._dataMatches[index] const claimData = this._matches[index]
let verificationResult, let verificationResult,
proofData = null, proofData = null,
@ -250,9 +250,9 @@ class Claim {
if (verificationResult.completed) { if (verificationResult.completed) {
// Store the result, keep a single match and stop verifying // Store the result, keep a single match and stop verifying
this._verification = verificationResult this._result = verificationResult
this._dataMatches = [claimData] this._matches = [claimData]
index = this._dataMatches.length index = this._matches.length
} }
} }
@ -270,11 +270,11 @@ class Claim {
if (this._status === E.ClaimStatus.INIT) { if (this._status === E.ClaimStatus.INIT) {
throw new Error('The claim has not been matched yet') throw new Error('The claim has not been matched yet')
} }
if (this._dataMatches.length === 0) { if (this._matches.length === 0) {
throw new Error('The claim has no matches') throw new Error('The claim has no matches')
} }
return ( return (
this._dataMatches.length > 1 || this._dataMatches[0].match.isAmbiguous this._matches.length > 1 || this._matches[0].match.isAmbiguous
) )
} }
@ -290,8 +290,8 @@ class Claim {
uri: this._uri, uri: this._uri,
fingerprint: this._fingerprint, fingerprint: this._fingerprint,
status: this._status, status: this._status,
dataMatches: this._dataMatches, matches: this._matches,
verification: this._verification, result: this._result,
} }
} }
} }