From e9fdeb0bf8931cf8e982acfd0eea2e3f1fe75cf3 Mon Sep 17 00:00:00 2001
From: Yarmo Mackenbach <yarmo@yarmo.eu>
Date: Thu, 17 Nov 2022 20:48:48 +0100
Subject: [PATCH] Change enum values to strings

---
 src/enums.js                  | 24 ++++++++++++------------
 test/claimDefinitions.test.js |  5 +----
 2 files changed, 13 insertions(+), 16 deletions(-)

diff --git a/src/enums.js b/src/enums.js
index e15486a..80e8172 100644
--- a/src/enums.js
+++ b/src/enums.js
@@ -61,17 +61,17 @@ Object.freeze(Fetcher)
 /**
  * Levels of access restriction for proof fetching
  * @readonly
- * @enum {number}
+ * @enum {string}
  */
 const ProofAccess = {
   /** Any HTTP request will work */
-  GENERIC: 0,
+  GENERIC: 'generic',
   /** CORS requests are denied */
-  NOCORS: 1,
+  NOCORS: 'nocors',
   /** HTTP requests must contain API or access tokens */
-  GRANTED: 2,
+  GRANTED: 'granted',
   /** Not accessible by HTTP request, needs server software */
-  SERVER: 3
+  SERVER: 'server'
 }
 Object.freeze(ProofAccess)
 
@@ -91,28 +91,28 @@ Object.freeze(ProofFormat)
 /**
  * Format of claim
  * @readonly
- * @enum {number}
+ * @enum {string}
  */
 const ClaimFormat = {
   /** `openpgp4fpr:123123123` */
-  URI: 0,
+  URI: 'uri',
   /** `123123123` */
-  FINGERPRINT: 1
+  FINGERPRINT: 'fingerprint'
 }
 Object.freeze(ClaimFormat)
 
 /**
  * How to find the claim inside the proof's JSON data
  * @readonly
- * @enum {number}
+ * @enum {string}
  */
 const ClaimRelation = {
   /** Claim is somewhere in the JSON field's textual content */
-  CONTAINS: 0,
+  CONTAINS: 'contains',
   /** Claim is equal to the JSON field's textual content */
-  EQUALS: 1,
+  EQUALS: 'equals',
   /** Claim is equal to an element of the JSON field's array of strings */
-  ONEOF: 2
+  ONEOF: 'oneof'
 }
 Object.freeze(ClaimRelation)
 
diff --git a/test/claimDefinitions.test.js b/test/claimDefinitions.test.js
index 66b78b8..68a79a2 100644
--- a/test/claimDefinitions.test.js
+++ b/test/claimDefinitions.test.js
@@ -44,7 +44,7 @@ const pattern = {
     },
     request: {
       fetcher: _.isString,
-      access: _.isInteger,
+      access: _.isString,
       format: _.isString,
       data: _.isObject,
     },
@@ -52,9 +52,6 @@ const pattern = {
   claim: (x) => {
     return _.isObject(x) || _.isArray(x)
   },
-  functions: (x) => {
-    return _.isObject(x) || _.isUndefined(x)
-  },
 }
 
 doipjs.claimDefinitions.list.forEach((claimDefName, i) => {