be83281f58
The issue was that our build pipeline uses 'go get' call to install golint, which changed the go.mod/go.sum files (not good, but I hadn't noticed before). Due to Golang bug #44129, this caused breakage on the dependencies of certain modules we use. The fix was to switch to 'go install golang.org/x/lint/golint@latest'. The addition of '@latest' puts 'go install' in module aware mode, which no longer changes go.mod file in the current directory. This is better, and it also avoids bug #44129. This commit also has a change due to `go mod tidy`. Finally, I had to add a longer timeout for the golangci-lint installation step in the github actions workflow, since that seems to take a bit over a minute now. This step is usually cached on subsequent runs, so we hadn't seen that failure before.
46 lines
1.2 KiB
YAML
46 lines
1.2 KiB
YAML
name: CI
|
|
|
|
on: [push, pull_request]
|
|
|
|
jobs:
|
|
# The "build" workflow
|
|
build:
|
|
# The type of runner that the job will run on
|
|
runs-on: ubuntu-latest
|
|
|
|
# Steps represent a sequence of tasks that will be executed as part of the job
|
|
steps:
|
|
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
|
|
- uses: actions/checkout@v2
|
|
|
|
# Install and run golangci-lint as a separate step, it's much faster this
|
|
# way because this action has caching. It'll get run again in `make lint`
|
|
# below, but it's still much faster in the end than installing
|
|
# golangci-lint manually in the `Run lint` step.
|
|
- uses: golangci/golangci-lint-action@v2
|
|
with:
|
|
args: --timeout 2m
|
|
|
|
# Setup Go
|
|
- name: Setup Go
|
|
uses: actions/setup-go@v2
|
|
with:
|
|
go-version: '1.16.3' # The Go version to download (if necessary) and use.
|
|
|
|
# Install all the dependencies
|
|
- name: Install dependencies
|
|
run: |
|
|
go version
|
|
go install golang.org/x/lint/golint@latest
|
|
sudo apt update
|
|
sudo apt install -y make
|
|
|
|
- name: Run tests
|
|
run: make test
|
|
|
|
- name: Run lint
|
|
run: make lint
|
|
|
|
- name: Run build
|
|
run: make
|
|
|